-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iana considerations section #71
Conversation
I think we need some IANA registration, or at least some codec info for IETF formats, I added a comment on CELLAR list: https://www.ietf.org/mail-archive/web/cellar/current/msg01168.html |
8d34560
to
23ce66e
Compare
updated for a new review |
ffv1.md
Outdated
|
||
See [the "Security Considerations" section](#security-considerations) of RFC xxxx. | ||
|
||
[RFC Editor: Upon publication as an RFC, please replace "XXXX" with the number assigned to this document and remove this note.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the need to indicate the number of this RFC here if it stays in the same RFC? I suggest to remove " of RFC xxxx".
|
||
This parameter is used to signal the capabilities of a receiver implementation. This parameter MUST NOT be used for any other purpose. | ||
|
||
version: The version of the FFV1 encoding as defined by [in the section on `version`](#version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put version[.micro_version].
Similar to https://www.iana.org/assignments/media-types/video/H264 parameters, I would add coder_type, color_space and bits_per_raw_sample, as some decoders may support only some combinations or we may add new coder_type, color_space in the future (like H.264 decoders support only some profiles and/or levels and standard adds new profiles later). Adding chroma subsampling info and others is maybe too much?
Reading IANA consideration for H264, max-fs (frame size), max-br (bit rate), something about max count of slices, could be taken into consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pr is updated to consider this comment. please re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me but willing another pair of eyes on it, I am not confident enough that I saw everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, I suspect we'll get a better review when reviewed by the area director or iesg, but for now I hope we have consensus amongst participating contributors/reviewers.
23ce66e
to
14d8ed2
Compare
ffv1.md
Outdated
|
||
Restrictions on usage: None. | ||
|
||
Author: TODO [Pick a contact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelni, may I set you as the IANA contact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dericed, what does the IANA contact has to do ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michaelni, the definition of the contact in the media type registration from rfc4855 is only
Person (including contact information) to contact for further information.
IIUC this contact only applies to the media type registration of IANA, but if IANA has some questions during the registration they need a specific contact. If you'd rather not, I could volunteer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh, ok, feel free to add me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelni I added you as contact and myself as the author of the registration section.
14d8ed2
to
116dbf0
Compare
Updated to add contact names, please re-review. |
this breaks build, please test build before approving changes draft-ietf-cellar-ffv1-01.xml: Line 1490: IDREF attribute target references an unknown ID "color_space" |
It seems the _ are lost in the anchors, i wonder how that happens |
No description provided.